sfc-gh-aixu commented on code in PR #247: URL: https://github.com/apache/polaris/pull/247#discussion_r1761598285
########## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisSequenceUtil.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.persistence.impl.eclipselink; + +import jakarta.persistence.*; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicBoolean; +import org.apache.polaris.core.persistence.models.ModelSequenceId; +import org.eclipse.persistence.internal.jpa.EntityManagerImpl; +import org.eclipse.persistence.platform.database.DatabasePlatform; +import org.eclipse.persistence.platform.database.PostgreSQLPlatform; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Used to generate sequence IDs for Polaris entities. If the legacy `POLARIS_SEQ` generator is + * available it will be used then cleaned up. In all other cases the `POLARIS_SEQUENCE` table is + * used directly. + */ +class PolarisSequenceUtil { Review Comment: Can you help me understand the purpose of this change? Is this to handle different syntax for different databases? ########## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ########## @@ -280,8 +283,8 @@ public void runActionInTransaction( LOGGER.debug("transaction committed"); } } catch (Exception e) { + LOGGER.debug("Rolled back transaction due to an error", e); tr.rollback(); Review Comment: Currently, we would retry if OptimisticLockException is hit - concurrent access. Yeah, we can collect what can be retried here. I remember the caller will do retry. Is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
