janl commented on code in PR #9177:
URL: https://github.com/apache/pouchdb/pull/9177#discussion_r2832375788
##########
packages/node_modules/pouchdb-abstract-mapreduce/src/index.js:
##########
@@ -303,10 +300,7 @@ function createAbstractMapReduce(localDocName, mapper,
reducer, ddocValidator) {
throw new Error(row.reason);
}
}
-
Review Comment:
doesn't this make this code path synchronous instead of asynchronous? I have
not looked at the bigger picture yet, but my gut feeling says that handling
attachments (large binary values) probably wants to be async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
