emilygilberts commented on code in PR #9177:
URL: https://github.com/apache/pouchdb/pull/9177#discussion_r2839922365
##########
packages/node_modules/pouchdb-abstract-mapreduce/src/index.js:
##########
@@ -303,10 +300,7 @@ function createAbstractMapReduce(localDocName, mapper,
reducer, ddocValidator) {
throw new Error(row.reason);
}
}
-
Review Comment:
Good question! I was thinking that its safe on this call since the function
`addHttpParam` is already async and before calling `postprocessAttachments` we
still await the `db.fetch` and `response.json`.
I thought that since `postprocessAttachments` and
`readAttachmentsAsBlobOrBuffer` themselves are synchronous, wrapping the result
in a Promise and calling `postprocessAttachments` on `.then()` only slightly
delays the call? - if not this is definitely where my confusion lies! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
