sijie commented on a change in pull request #2578: Add support for schema
extraction from a jar
URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r219038542
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
##########
@@ -34,6 +38,7 @@ public CmdSchemas(PulsarAdmin admin) {
jcommander.addCommand("get", new GetSchema());
jcommander.addCommand("delete", new DeleteSchema());
jcommander.addCommand("upload", new UploadSchema());
+ jcommander.addCommand("pojo", new PojoSchema());
Review comment:
`pojo` is not an "action" here. why can't we add the options to `upload`,
which I think it is the better place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
