sijie commented on a change in pull request #2578: Add support for schema
extraction from a jar
URL: https://github.com/apache/incubator-pulsar/pull/2578#discussion_r219038438
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java
##########
@@ -83,4 +88,44 @@ void run() throws Exception {
}
}
+ @Parameters(commandDescription = "Provide the schema via a topic")
+ private class PojoSchema extends CliCommand {
+ @Parameter(description = "persistent://tenant/namespace/topic",
required = true)
+ private java.util.List<String> params;
+
+ @Parameter(names = { "-j", "--jar" }, description = "jar filepath",
required = true)
+ private String jarFilePath;
+
+ @Parameter(names = { "-t", "--type" }, description = "type avro or
json", required = true)
+ private String type;
+
+ @Parameter(names = { "-c", "--class-name" }, description = "class name
of pojo", required = true)
Review comment:
`--class-name` to `--classname`. `--classname` is more common than
`--class-name`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
