david-streamlio commented on a change in pull request #2865: Refactored JCloud
Tiered Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r229406154
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/OffloadIndexBlock.java
##########
@@ -73,7 +71,7 @@
/**
* An input stream which knows the size of the stream upfront.
*/
- public static class IndexInputStream extends FilterInputStream {
+ class IndexInputStream extends FilterInputStream {
Review comment:
The reason I removed both the "public" and "static" modifiers for this
class, was due to the fact that check style flagged them both as redundant.
According to the java 8 spec,
https://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.5;
"Interfaces may contain member type declarations (ยง8.5).
A member type declaration in an interface is implicitly public and static."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
