david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r229778316
########## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/JCloudLedgerOffloaderFactory.java ########## @@ -24,6 +24,8 @@ import org.apache.bookkeeper.common.util.OrderedScheduler; import org.apache.bookkeeper.mledger.LedgerOffloaderFactory; import org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreManagedLedgerOffloader; +import org.apache.bookkeeper.mledger.offload.jcloud.provider.JCloudBlobStoreProvider; +import org.apache.bookkeeper.mledger.offload.jcloud.provider.TieredStorageConfiguration; /** * A jcloud based offloader factory. Review comment: I agree, but it isn't a class I added to the code base as part of the refactor. It was there previously, so I just left it in. As far as I can tell, it was added in the 2.2.0 release. It appears to be the code that is responsible for instantiating the tiered storage offloader ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
