ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r240268905
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
##########
@@ -111,6 +117,11 @@ public String getOffloadDriverName() {
return config.getOffloadDriverMetadata();
}
+ @VisibleForTesting
+ public ConcurrentMap<BlobStoreLocation, BlobStore> getBlobStores() {
Review comment:
This seems to exist for testing only. This is not necessary as you are
passing in the config which you can mock to return a spied blobstore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
