ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r241366285
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java
##########
@@ -166,7 +169,7 @@ public void validate(TieredStorageConfiguration config)
throws IllegalArgumentEx
@Override
public BlobStore getBlobStore(TieredStorageConfiguration config) {
- BlobStore bs =
ContextBuilder.newBuilder(config.getDriver().toLowerCase())
+ BlobStore bs = ContextBuilder.newBuilder(this.getDriver())
Review comment:
Why remove the `.toLowerCase()`. S3 was a valid value previously, and has
been documented in places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
