merlimat commented on a change in pull request #3273: Adding config
auto.offset.reset to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r244858495
##########
File path:
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
##########
@@ -143,6 +146,7 @@ private PulsarKafkaConsumer(ConsumerConfig config,
Deserializer<K> keyDeserializ
groupId = config.getString(ConsumerConfig.GROUP_ID_CONFIG);
isAutoCommit =
config.getBoolean(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG);
+ strategy =
getStrategy(config.getString(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG));
Review comment:
Wouldn't this give error if `config` doesn't include the specified key?
Shouldn't we have a default there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
