merlimat commented on a change in pull request #3273: Adding config
auto.offset.reset to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r244908804
##########
File path:
pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
##########
@@ -492,9 +508,21 @@ public void seekToEnd(Collection<TopicPartition>
partitions) {
@Override
public long position(TopicPartition partition) {
Long offset = lastReceivedOffset.get(partition);
- return offset != null ? offset : -1l;
+ if (offset == null) {
+ return resetOffsets(partition).getValue();
+ }
+ return offset;
}
+ private SubscriptionInitialPosition resetOffsets(final TopicPartition
partition) {
+ if (strategy == SubscriptionInitialPosition.Earliest) {
+ seekToBeginning(Collections.singleton(partition));
Review comment:
There are still several cases with tabs instead of spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
