merlimat commented on a change in pull request #3703: Added support for
"negative acks" in Java client
URL: https://github.com/apache/pulsar/pull/3703#discussion_r261030142
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -174,6 +175,7 @@ protected ConsumerImpl(PulsarClientImpl client, String
topic, ConsumerConfigurat
this.priorityLevel = conf.getPriorityLevel();
this.readCompacted = conf.isReadCompacted();
this.subscriptionInitialPosition =
conf.getSubscriptionInitialPosition();
+ this.negativeAcksTracker = new NegativeAcksTracker(this, conf);
Review comment:
If a user doesn't call negativeAck there won't be much overhead anyway.
Also, whether the feature is required by client, will be determined by the
client calling the API or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
