merlimat commented on a change in pull request #3703: Added support for
"negative acks" in Java client
URL: https://github.com/apache/pulsar/pull/3703#discussion_r261033334
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -174,6 +175,7 @@ protected ConsumerImpl(PulsarClientImpl client, String
topic, ConsumerConfigurat
this.priorityLevel = conf.getPriorityLevel();
this.readCompacted = conf.isReadCompacted();
this.subscriptionInitialPosition =
conf.getSubscriptionInitialPosition();
+ this.negativeAcksTracker = new NegativeAcksTracker(this, conf);
Review comment:
we could keep the set initialized to null until the first nack is called.
That will bring the overhead down to the same level as a NoOpNegativeAcksTracker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
