tuteng commented on pull request #14044: URL: https://github.com/apache/pulsar/pull/14044#issuecomment-1029068294
> @tuteng - thanks for your contribution! I left some initial feedback. A few of the points are important to address. > > It's possible that this PR is supposed to need a PIP. I don't personally think we need one, considering the scope of the PR and the fact that it is a reasonable addition to the existing interfaces. However, I'm not sure that I can officially waive the PIP process here. @michaeljmarshall I think that probably doesn't need a PIP, because this pr just adds a new interface and then fixes some wrong method signatures, and this pr is backward compatible, but if more people think it needs a PIP, I guess I could consider adding it, but I don't seem to have much to introduce, because the auth state passing of the pulsar protocol has already been implemented, and now it's just an optimization of auth state passing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
