nodece commented on a change in pull request #14069:
URL: https://github.com/apache/pulsar/pull/14069#discussion_r801264888
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -1151,28 +1151,29 @@ public void testDeleteTopic() throws Exception {
BrokerService brokerService = spy(pulsar.getBrokerService());
doReturn(brokerService).when(pulsar).getBrokerService();
persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, false, null);
+
CompletableFuture<Void> deleteTopicFuture = new CompletableFuture<>();
deleteTopicFuture.completeExceptionally(new
MetadataStoreException.NotFoundException());
doReturn(deleteTopicFuture).when(brokerService).deleteTopic(anyString(),
anyBoolean(), anyBoolean());
- persistentTopics.deleteTopic(testTenant, testNamespace, topicName,
true, true, true);
- //
+ AsyncResponse response = mock(AsyncResponse.class);
+ ArgumentCaptor<Response> responseCaptor =
ArgumentCaptor.forClass(Response.class);
+ persistentTopics.deleteTopic(response, testTenant, testNamespace,
topicName, true, true, true);
+ verify(response,
timeout(5000).times(1)).resume(responseCaptor.capture());
+
+ ArgumentCaptor<RestException> errorCaptor =
ArgumentCaptor.forClass(RestException.class);
CompletableFuture<Void> deleteTopicFuture2 = new CompletableFuture<>();
deleteTopicFuture2.completeExceptionally(new
MetadataStoreException("test exception"));
doReturn(deleteTopicFuture2).when(brokerService).deleteTopic(anyString(),
anyBoolean(), anyBoolean());
- try {
- persistentTopics.deleteTopic(testTenant, testNamespace, topicName,
true, true, true);
- } catch (Exception e) {
- Assert.assertTrue(e instanceof RestException);
- }
- //
+ response = mock(AsyncResponse.class);
+ persistentTopics.deleteTopic(response, testTenant, testNamespace,
topicName, true, true, true);
+ verify(response, timeout(5000).times(1)).resume(errorCaptor.capture());
+
Review comment:
Please check the `errorCaptor.getValue()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
