codelipenghui commented on a change in pull request #14064:
URL: https://github.com/apache/pulsar/pull/14064#discussion_r801673522
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -3289,23 +3289,38 @@ private RetentionPolicies
getRetentionPolicies(TopicName topicName, TopicPolicie
}
- protected MessageId internalTerminate(boolean authoritative) {
+ protected void internalTerminateAsync(AsyncResponse asyncResponse, boolean
authoritative) {
Review comment:
We'd better make this method return `CompletableFuture<MessageId>`, it's
hard to get the response type for the rest API, only can be found here
https://github.com/apache/pulsar/pull/14064/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1R3317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
