congbobo184 opened a new pull request #14170:
URL: https://github.com/apache/pulsar/pull/14170


   link #8318
   
   ### Motivation
   in #8318, we delete transaction marker should check the markDeletePosition 
next position is marker or not, because we don't have the maxReadPosition in 
TopicTransaction buffer, but in #9195 we have implemented maxReadPosition. 
Consumer only can receive the messageId is smaller than maxReadPosition. So 
marker have no value for this subscription.
   
   ### Modifications
   
   1. delete the current delete transaction marker logical 
   2. when dispatch the message, the message is transaction marker, we can ack 
the marker directly.
   
   ### Verifying this change
   add the test
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup 
issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to