congbobo184 commented on a change in pull request #14170:
URL: https://github.com/apache/pulsar/pull/14170#discussion_r801750214
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java
##########
@@ -160,6 +160,10 @@ public int
filterEntriesForConsumer(Optional<EntryWrapper[]> entryWrapper, int e
if (!isReplayRead && msgMetadata != null &&
msgMetadata.hasTxnidMostBits()
&& msgMetadata.hasTxnidLeastBits()) {
if (Markers.isTxnMarker(msgMetadata)) {
+ // because consumer can receive message is smaller than
maxReadPosition,
+ // so this marker is no value for this subscription
+
subscription.acknowledgeMessage(Collections.singletonList(entry.getPosition()),
AckType.Individual,
+ Collections.emptyMap());
Review comment:
entriesToFiltered may be null when no entryFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
