tuteng commented on a change in pull request #14044:
URL: https://github.com/apache/pulsar/pull/14044#discussion_r802241334



##########
File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/FunctionApiResource.java
##########
@@ -54,7 +54,7 @@ public String clientAppId() {
                 : null;
     }
 
-    public AuthenticationDataHttps clientAuthData() {
-        return (AuthenticationDataHttps) 
httpRequest.getAttribute(AuthenticationFilter.AuthenticatedDataAttributeName);
+    public AuthenticationDataSource clientAuthData() {
+        return (AuthenticationDataSource) 
httpRequest.getAttribute(AuthenticationFilter.AuthenticatedDataAttributeName);

Review comment:
       Use AuthenticationDataSource to allow users to customize their own auth 
state, if the default is to use AuthenticationDataHttps as the return value, it 
will not allow users to customize the auth state




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to