mattisonchao commented on a change in pull request #14259:
URL: https://github.com/apache/pulsar/pull/14259#discussion_r805538113
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -993,10 +994,12 @@ private void
internalUnloadTransactionCoordinatorAsync(AsyncResponse asyncRespon
asyncResponse.resume(Response.noContent().build());
}))
.exceptionally(ex -> {
- Throwable cause = ex.getCause();
- log.error("[{}] Failed to unload tc {},{}", clientAppId(),
- topicName.getPartitionIndex(), cause);
- resumeAsyncResponseExceptionally(asyncResponse, cause);
+ // If the exception is not redirect exception we need to
log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to unload tc {},{}",
clientAppId(),
+ topicName.getPartitionIndex(), ex);
+ }
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
Hi @hangc0276
``resumeAsyncResponseExceptionally `` method has unwrapped the exception.
https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L764-L774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
