mattisonchao commented on a change in pull request #14259:
URL: https://github.com/apache/pulsar/pull/14259#discussion_r805538946
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -753,22 +751,23 @@ protected void internalUnloadTopic(AsyncResponse
asyncResponse, boolean authorit
} else {
internalUnloadNonPartitionedTopicAsync(asyncResponse, authoritative);
}
- }).exceptionally(t -> {
- log.error("[{}] Failed to get partitioned metadata
while unloading topic {}",
- clientAppId(), topicName, t);
- if (t instanceof WebApplicationException) {
- asyncResponse.resume(t);
- } else {
- asyncResponse.resume(new RestException(t));
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we
need to log it.
+ if (!isRedirectException(ex)) {
Review comment:
Looks like we don't change the original logic because
``resumeAsyncResponseExceptionally`` will do the same things.
I just let the redirect exception not log the error.
The detail:
https://github.com/apache/pulsar/blob/6d717a08ef8cfcac032caee06105285594baf09f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L764-L774
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -1753,19 +1760,12 @@ protected void internalSkipAllMessages(AsyncResponse
asyncResponse, String subNa
}
})
.exceptionally(ex -> {
- Throwable cause = FutureUtil.unwrapCompletionException(ex);
- if (cause instanceof WebApplicationException) {
- if (log.isDebugEnabled()) {
- log.debug("[{}] Failed to skip all messages for
subscription on topic {},"
- + " redirecting to other brokers.",
- clientAppId(), topicName, cause);
- }
- resumeAsyncResponseExceptionally(asyncResponse, cause);
- } else {
+ // If the exception is not redirect exception we need to
log it.
+ if (!isRedirectException(ex)) {
log.error("[{}] Failed to skip all messages for
subscription {} on topic {}",
- clientAppId(), subName, topicName, cause);
+ clientAppId(), subName, topicName, ex);
}
- resumeAsyncResponseExceptionally(asyncResponse, cause);
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
``FutureUtil.unwrapCompletionException(ex)`` already exist in the
``resumeAsyncResponseExceptionally`` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
