michaeljmarshall commented on pull request #14306: URL: https://github.com/apache/pulsar/pull/14306#issuecomment-1041057960
> @michaeljmarshall I think the bug is just in Go client code that is passing an empty string instead of omitting the field. Yes, that is exactly what it looks like to me, given that the types don't align (`string` vs `*string`), so the zero values are different. If it's too hard to implement the test, I will approve it here. My main point is that we're providing special treatment for a non-zero value field. I think it is fine because we're making an exception for any blank string, which is meaningless in this context, but my motivation in requesting changes is that I prefer explicit protocol documentation reinforced by tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
