EronWright commented on pull request #14306: URL: https://github.com/apache/pulsar/pull/14306#issuecomment-1042055789
There's a limit to what may be expressed in the protocol definition, e.g. one cannot express that the `advertised_listener_name` be non-empty when set, or match a certain regex. Of course the protocol supports the concept of optionality, but this is insufficient; some server-side validation is generally necessary. In retrospect, maybe the server should have rejected the request as semantically invalid, e.g. 'no such listener named (empty string)', but that would be a breaking change. Note that the problem also exists in the cpp client ([ref](https://github.com/apache/pulsar/blob/e3c9684aa8a23daa241644cd742dfdb24dba71bc/pulsar-client-cpp/lib/Commands.cc#L114-L128)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
