tjiuming commented on pull request #14453: URL: https://github.com/apache/pulsar/pull/14453#issuecomment-1053446892
> Actually, I am just curious if there is some situation that it's better not use this feature, maybe like metric data is under 50MB? `Avoid more than once PrometheusMetricsGenerator#generate invoke in a period(1 minute), for the purpose of saving memory and reducing CPU usage.` This can be configurable, I'll add a configuration if needed. `Canceled persist data to temp files, maybe broker has a poor performance disk, so use CompositeDirectByteBuf only.` But this, we cannot know how much metrics data will be wrote to clients before it generated. So, it cannot be disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
