tjiuming commented on pull request #14453: URL: https://github.com/apache/pulsar/pull/14453#issuecomment-1053459602
> Nice work. We should make this configurable. In case we have a bug and we want to disable this feature Thanks. `Avoid more than once PrometheusMetricsGenerator#generate invoke in a period(1 minute), for the purpose of saving memory and reducing CPU usage.` This feature is a precursor. What I want is in the future we can clean all the metrics objects after metrics data generated, it can be release a lot of objects and reduce heap memory usage if there are over 1 million topics in a broker. Many metrics exported as `Gauges`, so we don't have to depend on `rate/irate` functions to aggregate these metrics. It can be reduce prometheus's pressure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
