michaeljmarshall commented on a change in pull request #14602:
URL: https://github.com/apache/pulsar/pull/14602#discussion_r824240247
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -2209,5 +2234,11 @@ boolean isErrorStat() {
return errorState;
}
+ @VisibleForTesting
Review comment:
Unless I'm missing something, I think we can get rid of this annotation
since it is a part of the public API, and it is visible for more than just
testing.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -2209,5 +2234,11 @@ boolean isErrorStat() {
return errorState;
}
+ @VisibleForTesting
+ CompletableFuture<Void> getOriginalLastSendFuture() {
Review comment:
Since we added this to both `ProducerImpl` and
`PartitionedProducerImpl`, should we consider adding this to the `Producer`
interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
