michaeljmarshall commented on a change in pull request #14602:
URL: https://github.com/apache/pulsar/pull/14602#discussion_r826348237
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Producer.java
##########
@@ -199,4 +199,9 @@
* @return the number of partitions per topic.
*/
int getNumOfPartitions();
+
+ /**
+ * @return Get the result of the last sent data
+ */
+ CompletableFuture<Void> getOriginalLastSendFuture();
Review comment:
While the method is no longer added to the interface, it is still
exposed to end users in the most recent commit. Is the method meant for
internal use only, or is user code supposed to call the method? If user code is
supposed to call the method, and all producer implementations have their own
implementation, then I think we should put the method in this interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
