aloyszhang commented on a change in pull request #14655:
URL: https://github.com/apache/pulsar/pull/14655#discussion_r825545252
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##########
@@ -37,7 +37,7 @@
CompletableFuture<SchemaVersion> putSchemaIfAbsent(String schemaId,
SchemaData schema,
SchemaCompatibilityStrategy strategy);
- CompletableFuture<SchemaVersion> deleteSchema(String schemaId, String
user);
+ CompletableFuture<SchemaVersion> deleteSchema(String schemaId, String
user, boolean force);
Review comment:
It's an alternative way. Since this method is not oriented to users(not
a breaking change), IMO, we can modify the original method instead of adding a
new one. Adding a new method will leave more duplicated codes, I did see many
benefits for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
