lhotari commented on a change in pull request #14687:
URL: https://github.com/apache/pulsar/pull/14687#discussion_r826676999
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1916,20 +1916,20 @@ protected void completeOpBatchReceive(OpBatchReceive<T>
op) {
if (messageIds == null || messageIds.isEmpty()) {
return CompletableFuture.completedFuture(Collections.emptyList());
}
- List<MessageIdData> data = new ArrayList<>(messageIds.size());
- List<CompletableFuture<Void>> futures = new
ArrayList<>(messageIds.size());
- messageIds.forEach(messageId -> {
+ List<CompletableFuture<MessageIdData>> futures =
messageIds.stream().map(messageId -> {
CompletableFuture<Boolean> future =
processPossibleToDLQ(messageId);
- futures.add(future.thenAccept(sendToDLQ -> {
+ return future.thenApply(sendToDLQ -> {
if (!sendToDLQ) {
- data.add(new MessageIdData()
+ return new MessageIdData()
.setPartition(messageId.getPartitionIndex())
.setLedgerId(messageId.getLedgerId())
- .setEntryId(messageId.getEntryId()));
+ .setEntryId(messageId.getEntryId());
}
- }));
- });
- return FutureUtil.waitForAll(futures).thenCompose(v ->
CompletableFuture.completedFuture(data));
+ return null;
+ });
+ }).collect(Collectors.toList());
+ return FutureUtil.waitForAll(futures).thenApply(v ->
+
futures.stream().map(CompletableFuture::join).filter(Objects::nonNull).collect(Collectors.toList()));
Review comment:
To implement a non-blocking reduction to a list, one would have to use
`CompletableFuture.thenCombine` and reduce pair wise until there's a single
result list. I didn't find a code example of this, but
https://stackoverflow.com/a/65654939 is in that direction.
Most Stackoverflow examples suggest using CompletableFuture::join which
isn't a non-blocking approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
