lhotari commented on a change in pull request #14687:
URL: https://github.com/apache/pulsar/pull/14687#discussion_r826735415



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1916,20 +1916,20 @@ protected void completeOpBatchReceive(OpBatchReceive<T> 
op) {
         if (messageIds == null || messageIds.isEmpty()) {
             return CompletableFuture.completedFuture(Collections.emptyList());
         }
-        List<MessageIdData> data = new ArrayList<>(messageIds.size());

Review comment:
       (since the futures based solution is fine, this comment can be ignored)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to