congbobo184 commented on a change in pull request #3876: Add the multi version
schema support
URL: https://github.com/apache/pulsar/pull/3876#discussion_r269873516
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -83,6 +83,7 @@
private final ConnectionPool cnxPool;
private final Timer timer;
private final ExecutorProvider externalExecutorProvider;
+ private Map<String, Schema> supportSchemaVersioningSchemaCache = new
HashMap<>();
Review comment:
I think the topic is the first key, the true avro schema is second key. like
this
private Map<String, ConcurrentHashMap<org.apache.avro.Schema,Schema>>
supportSchemaVersioningSchemaCache = new HashMap<>
```suggestion
private Map<String, Schema> supportSchemaVersioningSchemaCache = new
HashMap<>();
```
Because schema by version will create a lot of same reader and writer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
