congbobo184 commented on a change in pull request #3876: Add the multi version
schema support
URL: https://github.com/apache/pulsar/pull/3876#discussion_r274813333
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaProvider.java
##########
@@ -31,6 +31,14 @@
* @param schemaVersion schema version
* @return schema instance of the provided <tt>schemaVersion</tt>
*/
- Schema<T> getSchema(byte[] schemaVersion);
+ Schema<T> getSchemaByVersion(byte[] schemaVersion);
Review comment:
> After reading through the code, it seems that we don't actually need a
Schema instance here but we only need SchemaInfo. so it might be better to just
return `SchemaInfo` here
>
> interface SchemaProvider {
>
> SchemaInfo getSchemaByVersion(byte[] schemaVersion);
>
> SchemaInfo getLatestSchema();
>
> String getTopicName();
>
> }
okey, change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
