michaeljmarshall commented on issue #13429:
URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1069701501
@oversearch - thanks for your note. An interesting detail is that we're
building in a VM, so I would think we could have control over which compiler
we're using. I am new to building our C++ client, so I am not very opinionated
on how to solve it.
When I removed the `-Wno-error=cpp` line from the `CMakeLists.txt`, I made
it further in the build, but failed with this error:
```
default:
/Users/vagrant/pulsar/pulsar-client-cpp/lib/stats/ProducerStatsImpl.cc:29:45:
error: suggest braces around initialization of subobject
[-Werror,-Wmissing-braces]
default: static const std::array<double, 4> probs = {0.5, 0.9, 0.99,
0.999};
default:
^~~~~~~~~~~~~~~~~~~~~
default: {
}
default: 1 error generated.
default: make[3]: ***
[lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/stats/ProducerStatsImpl.cc.o] Error 1
default: make[3]: *** Waiting for unfinished jobs....
default: make[2]: *** [lib/CMakeFiles/PULSAR_OBJECT_LIB.dir/all] Error 2
default: make[1]: *** [python/CMakeFiles/_pulsar.dir/rule] Error 2
default: make: *** [_pulsar] Error 2
```
Note that I don't see the `-Werror=cpp` anywhere in our repo. I only see
`-Wno-error=cpp` as well as `-Werror`.
@merlimat - I'm wondering if I should have someone build this on a Linux for
now so that we don't block the 2.8.3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
