michaeljmarshall commented on issue #13429: URL: https://github.com/apache/pulsar/issues/13429#issuecomment-1072751456
> Ideally we'd add another branch for AppleClang that has the proper flag so that this works, because warnings as errors is a valuable tool for hardening any C++ code base. Although given the range of compliers y'all need to support, maybe it's more trouble than it's worth... my experience is mostly with big commercial code bases where there's only one or two compilers that need to be supported. @oversearch - is it reasonable to remove the `-Wno-error=cpp` option? Or should we pursue the branching logic based on the compiler? I can remove the option, but I'm not familiar enough with C++ to create a separate branch in the build process. I tried to add an option to ignore unknown options, but that option is itself not universal to all compilers, so that PR's build failed due to an unknown option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
