llIlll commented on code in PR #15010:
URL: https://github.com/apache/pulsar/pull/15010#discussion_r844119641
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java:
##########
@@ -146,18 +153,22 @@ private PulsarCluster(PulsarClusterSpec spec, CSContainer
csContainer, boolean s
// create bookies
bookieContainers.putAll(
- runNumContainers("bookie", spec.numBookies(), (name) -> new
BKContainer(clusterName, name)
- .withNetwork(network)
- .withNetworkAliases(appendClusterName(name))
- .withEnv("zkServers",
appendClusterName(ZKContainer.NAME))
- .withEnv("useHostNameAsBookieID", "true")
- // Disable fsyncs for tests since they're slow within
the containers
- .withEnv("journalSyncData", "false")
- .withEnv("journalMaxGroupWaitMSec", "0")
- .withEnv("clusterName", clusterName)
- .withEnv("diskUsageThreshold", "0.99")
- .withEnv("nettyMaxFrameSizeBytes", "" +
spec.maxMessageSize)
- )
+ runNumContainers("bookie", spec.numBookies(), (name) -> {
+ BKContainer bkContainer = new BKContainer(clusterName,
name)
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]