llIlll commented on code in PR #15010:
URL: https://github.com/apache/pulsar/pull/15010#discussion_r844127058
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java:
##########
@@ -143,11 +143,11 @@ public ProxyServiceStarter(String[] args) throws
Exception {
// load config file
config = PulsarConfigurationLoader.create(configFile,
ProxyConfiguration.class);
- if (isBlank(metadataStoreUrl)) {
- // Use zookeeperServers from command line if metadataStoreUrl
is empty;
- config.setMetadataStoreUrl(zookeeperServers);
- } else {
- // Use metadataStoreUrl from command line
+ if (!isBlank(zookeeperServers)) {
+ config.setZookeeperServers(zookeeperServers);
Review Comment:
Previously AbstractZkLedgerManager was used to create LedgerManagerFactory.
In this issue, MetadataDriver was used to create LedgerManagerFactory, but
their uri were different, so the zk test case would fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
