horizonzy opened a new pull request, #15098: URL: https://github.com/apache/pulsar/pull/15098
Master Issue: #5669 #5809 ### Motivation Relational code: https://github.com/apache/pulsar/blob/af351647710a9f5787d3cdc04cf9376895476eda/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java#L48-L63 https://github.com/apache/pulsar/blob/af351647710a9f5787d3cdc04cf9376895476eda/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L2230-L2245 In #5809, there be 3 potential problem. case 1: In `OpAddEntry` construction, it use `ManagedLedgerImpl#startReadOperationOnLedger` to setup readPosition, in startReadOperationOnLedger, it will callback OpAddEntry, but now some property not initial yet(like curtos,callback, entries...), cause npe. case 2: in startReadOperationOnLedger, the callback did't pass on ctx, the callback process need it, also case npe. case 3: in startReadOperationOnLedger, it didn't return when not found ledger id. The judgement unbox also case npe. https://github.com/apache/pulsar/blob/af351647710a9f5787d3cdc04cf9376895476eda/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L2238 ### Modifications patch #5809 ### Documentation - [ ] `no-need-doc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
