horizonzy commented on PR #15098: URL: https://github.com/apache/pulsar/pull/15098#issuecomment-1094206045
> Overall LGTM, but i have a question: Could we check for an `OpReadEntry` earlier (to avoid creating useless objects) or throw an exception (to achieve fail fast) when creating it? Please let me know what you think, thanks~ And the operation `startReadOperationOnLedger ` not only happen at opAddEntry construction, so I change the invalid in the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
