Anonymitaet commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851014807
##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a
transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a
TC,
Review Comment:
similar question to the last comment
##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a
transaction with `txnid_least_bits`
Review Comment:
```suggestion
* `txnid_most_bits` -> *(optional)* Same as TC ID. It uniquely identifies a
transaction with `txnid_most_bits`
```
do you mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]