liangyepianzhou commented on code in PR #15177:
URL: https://github.com/apache/pulsar/pull/15177#discussion_r851206435
##########
site2/docs/developing-binary-protocol.md:
##########
@@ -412,6 +412,12 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC Id, uniquely identify a
transaction with `txnid_least_bits`
+ * `txnid_least_bits` -> *(optional)* The id of the transaction opened in a
TC,
+ uniquely identify a transaction with `txnid_most_bits`
+ * `request_id` -> *(optional)* Id for handling response and timeout
Review Comment:
I also think it may be better to use ID, but other similar places in this
file use Id. Is it inappropriate for us to modify the Id here alone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
