Jason918 commented on code in PR #15198:
URL: https://github.com/apache/pulsar/pull/15198#discussion_r852031995


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java:
##########
@@ -144,7 +145,7 @@ protected void initChannel(SocketChannel ch) throws 
Exception {
         // auto-read.
         ch.pipeline().addLast("flowController", new FlowControlHandler());
         ServerCnx cnx = newServerCnx(pulsar, listenerName);
-        ch.pipeline().addLast("handler", cnx);
+        ch.pipeline().addLast("handler", (ChannelHandler) cnx);

Review Comment:
   Sorry, I didn't get this. `ServerCnx` extends 
`ChannelInboundHandlerAdapter`, why is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to