[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15198: [fix][test]Fix cannot resolve method addLast error

Sun, 24 Apr 2022 20:55:15 -0700 


BewareMyPower commented on code in PR #15198:
URL: https://github.com/apache/pulsar/pull/15198#discussion_r857242077


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarChannelInitializer.java:
##########
@@ -144,7 +145,7 @@ protected void initChannel(SocketChannel ch) throws 
Exception {
         // auto-read.
         ch.pipeline().addLast("flowController", new FlowControlHandler());
         ServerCnx cnx = newServerCnx(pulsar, listenerName);
-        ch.pipeline().addLast("handler", cnx);
+        ch.pipeline().addLast("handler", (ChannelHandler) cnx);

Review Comment:
   <img width="1066" alt="image" 
src="https://user-images.githubusercontent.com/18204803/165018011-7e4bcf71-4395-4d6d-9246-b133a7ae5e30.png";>
   
   It looks like a bug of Idea, both `PulsarDecoder` and my customized 
`Decoder` extend the same class `ChannelInboundHandlerAdapter`, while 
inheriting `Decoder` works well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to