Technoboy- commented on code in PR #15252:
URL: https://github.com/apache/pulsar/pull/15252#discussion_r857102157
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TransactionTestBase.java:
##########
@@ -123,7 +125,7 @@ protected void setUpBase(int numBroker,int
numPartitionsOfTC, String topic, int
admin.tenants().createTenant(NamespaceName.SYSTEM_NAMESPACE.getTenant(),
new TenantInfoImpl(Sets.newHashSet("appid1"),
Sets.newHashSet(CLUSTER_NAME)));
admin.namespaces().createNamespace(NamespaceName.SYSTEM_NAMESPACE.toString());
-
admin.topics().createPartitionedTopic(TopicName.TRANSACTION_COORDINATOR_ASSIGN.toString(),
numPartitionsOfTC);
+ createTransactionCoordinatorAssign(numPartitionsOfTC);
Review Comment:
Ah, because TRANSACTION_COORDINATOR_ASSIGN is not a topic in fact. If we use
the old way to create it like `createPartitionedTopic `, we have to check the
name on the broker side to let it pass(like not to create managed ledger or
something).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
