Technoboy- commented on code in PR #15252:
URL: https://github.com/apache/pulsar/pull/15252#discussion_r857123395
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1372,11 +1373,18 @@ public static String
getSLAMonitorBrokerName(ServiceUnitId ns) {
}
public static boolean isSystemServiceNamespace(String namespace) {
- return HEARTBEAT_NAMESPACE_PATTERN.matcher(namespace).matches()
+ return SYSTEM_NAMESPACE.toString().equals(namespace)
+ || HEARTBEAT_NAMESPACE_PATTERN.matcher(namespace).matches()
Review Comment:
The test : OverloadShedderTest#testBrokerWithMultipleBundles could not pass.
Because the bundle data is not regular(namespace/bundle), so only have to keep
the original impmenetation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
