codelipenghui commented on code in PR #15312:
URL: https://github.com/apache/pulsar/pull/15312#discussion_r857609830


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java:
##########
@@ -106,6 +106,7 @@ public void testNegativeAcks(boolean batching, boolean 
usePartitions, Subscripti
         log.info("Test negative acks batching={} partitions={} subType={} 
negAckDelayMs={}", batching, usePartitions,
                 subscriptionType, negAcksDelayMillis);
         String topic = BrokerTestUtil.newUniqueName("testNegativeAcks");
+        admin.topics().createPartitionedTopic(topic, 2);

Review Comment:
   Should apply `usePartitions` to run test on partitioned topic and 
non-partitioned topic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to