mattisonchao commented on code in PR #15312:
URL: https://github.com/apache/pulsar/pull/15312#discussion_r857645032


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java:
##########
@@ -106,6 +106,9 @@ public void testNegativeAcks(boolean batching, boolean 
usePartitions, Subscripti
         log.info("Test negative acks batching={} partitions={} subType={} 
negAckDelayMs={}", batching, usePartitions,
                 subscriptionType, negAcksDelayMillis);
         String topic = BrokerTestUtil.newUniqueName("testNegativeAcks");
+        if (usePartitions) {
+            admin.topics().createPartitionedTopic(topic, 2);

Review Comment:
   Question: 
   I'm not sure if the topics that have been created before are cleaned up 
every time we run the tests? Will this affect the accuracy of the test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to