nicoloboschi commented on code in PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#discussion_r858922652
##########
build/run_unit_group.sh:
##########
@@ -78,8 +78,8 @@ function test_group_broker_client_impl() {
mvn_test -pl pulsar-broker -Dgroups='broker-impl'
}
-function test_group_broker_jdk8() {
- mvn_test -pl pulsar-broker -Dgroups='broker-jdk8'
-Dpulsar.allocator.pooled=true
+function test_group_broker_jdk17() {
Review Comment:
I don't think it is needed. The reason why the jdk8 existed is to ensure
server compatibility with jdk8.
You should check if those tests are included in other groups and eventually
drop this suite
##########
pulsar-client-cpp/docker-tests.sh:
##########
@@ -65,7 +65,10 @@ DISABLE_COLOR_OUTPUT=""
if [ "$GTEST_COLOR" = "no" ]; then
DISABLE_COLOR_OUTPUT="| cat"
fi
-$DOCKER_CMD bash -c "set -o pipefail; cd /pulsar/pulsar-client-cpp &&
./run-unit-tests.sh ${tests} $DISABLE_COLOR_OUTPUT"
+
+# Java17 is required for CLI e.g) bin/pulsar create-token
+$DOCKER_CMD bash -c "apt-get -y install openjdk-17-jre-headless &&\
Review Comment:
I expect this kind of setup in the docker image preparation in the Dockerfile
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/KinesisSinkTester.java:
##########
@@ -189,38 +194,56 @@ private void internalValidateSinkResult(Map<String,
String> kvs) {
Map<String, String> actualKvs = new LinkedHashMap<>();
- // millisBehindLatest equals zero when record processing is caught up,
- // and there are no new records to process at this moment.
- // See
https://docs.aws.amazon.com/kinesis/latest/APIReference/API_GetRecords.html#Streams-GetRecords-response-MillisBehindLatest
- Awaitility.await().until(() ->
addMoreRecordsAndGetMillisBehindLatest(actualKvs, iterator) == 0);
+ addMoreRecords(actualKvs, iterator);
Review Comment:
not related to this pull ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
