heesung-sn commented on code in PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#discussion_r858958245
##########
build/run_unit_group.sh:
##########
@@ -78,8 +78,8 @@ function test_group_broker_client_impl() {
mvn_test -pl pulsar-broker -Dgroups='broker-impl'
}
-function test_group_broker_jdk8() {
- mvn_test -pl pulsar-broker -Dgroups='broker-jdk8'
-Dpulsar.allocator.pooled=true
+function test_group_broker_jdk17() {
Review Comment:
We have only `ManagedLedgerCompressionTest` which tags `broker-jdk17`(and
`broker` too). I don't mind removing this `broker_jdk17` test as it is already
covered in the broker test, but it might be useful in the future when we start
supporting jdk18+, as a broker jdk base test, just like the original broker
jdk8 test.
```
@Test(groups = {"broker", "broker-jdk17"})
public class ManagedLedgerCompressionTest extends BrokerTestBase {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
