heesung-sn commented on code in PR #15264:
URL: https://github.com/apache/pulsar/pull/15264#discussion_r861947669
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/KinesisSinkTester.java:
##########
@@ -189,38 +194,56 @@ private void internalValidateSinkResult(Map<String,
String> kvs) {
Map<String, String> actualKvs = new LinkedHashMap<>();
- // millisBehindLatest equals zero when record processing is caught up,
- // and there are no new records to process at this moment.
- // See
https://docs.aws.amazon.com/kinesis/latest/APIReference/API_GetRecords.html#Streams-GetRecords-response-MillisBehindLatest
- Awaitility.await().until(() ->
addMoreRecordsAndGetMillisBehindLatest(actualKvs, iterator) == 0);
+ addMoreRecords(actualKvs, iterator);
Review Comment:
> @heesung-sn Just that you know about it, it's usually useful to work on
GitHub Actions workflow changes in your own fork before opening a PR to
apache/pulsar. Please check the comments in [#15385
(comment)](https://github.com/apache/pulsar/pull/15385#issuecomment-1113050807)
. When running builds in your own fork, you can also get ssh access to the
build VMs to investigate issues. ssh access is disabled because of security
reasons in apache/pulsar builds.
Thank you!!. I was actually looking for how to debug github workflow
locally. Let me take an action to update the pulsar contribution page with this
instruction too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
