heesung-sn commented on PR #15264: URL: https://github.com/apache/pulsar/pull/15264#issuecomment-1120050175
> @heesung-sn I reviewed the changes and since it would have been too hard to explain the details, I have push changes to an experiment that I'm running in my fork, it's [lhotari#69](https://github.com/lhotari/pulsar/pull/69) . I simplified the pulsar-ci.yaml changes to just this change: [lhotari@5521c54](https://github.com/lhotari/pulsar/commit/5521c543737b5aa0542f30d80c9bb7f3a19b2b2d) > > Instead of adding a new job, it was sufficient to extend the existing integration-tests matrix job and add a matrix property "runtime_jdk" example > > ``` > - name: Shade on Java 8 > group: SHADE_RUN > runtime_jdk: 8 > setup: ./build/run_integration_group.sh SHADE_BUILD > > - name: Shade on Java 11 > group: SHADE_RUN > runtime_jdk: 11 > setup: ./build/run_integration_group.sh SHADE_BUILD > > - name: Shade on Java 17 > group: SHADE_RUN > setup: ./build/run_integration_group.sh SHADE_BUILD > ``` > > There was already a feature to run a setup command. > > this would be the change to support the `runtime_jdk` matrix property: > > ``` > - name: Set up runtime JDK ${{ matrix.runtime_jdk }} > uses: actions/setup-java@v2 > if: ${{ matrix.runtime_jdk && needs.changed_files_job.outputs.docs_only != 'true' }} > with: > distribution: 'temurin' > java-version: ${{ matrix.runtime_jdk }} > ``` > > If the build runs fine in my fork, we could also proceed by synchronizing the changes to this PR. Are you fine with that? Thank you for further simplifying this CI test workflow change. I am ok with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
